8000 only order variable tree entities alphabetically by dmfalke · Pull Request #1324 · VEuPathDB/web-monorepo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

only order variable tree entities alphabetically #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

dmfalke
Copy link
Member
@dmfalke dmfalke commented Feb 7, 2025

Only order entities alphabetically in the variable tree components.

@dmfalke dmfalke requested a review from bobular February 7, 2025 17:08
Copy link
Member
@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmfalke
Copy link
Member Author
dmfalke commented Feb 7, 2025

Thanks for the quick review!

@dmfalke dmfalke merged commit 1bd16ac into main Feb 7, 2025
1 check passed
@dmfalke dmfalke deleted the eda-variableTree-order branch February 7, 2025 17:54
dmfalke added a commit that referenced this pull request Feb 18, 2025
* checkpoint

* Add type annotations to remove inferred `any` type.

* Allow an analysis descriptor to be provided to `useAnalysis`

* Only update state if the next param value is different than the previous
param value

* Extract useAnalysisState to allow external state tracking of analysis object

* Use useAnalysisState, add counts, etc

* Add stubbed question page with custom name

* Allow hiding starred variable feature

* fix typo

* Use global memoization

* Encapsulate creation of eda api clients

* Adhere to lastest "api" for GenesByEdaSubset

* dont wrap sentence

* fix label in user comment upload form

* Fix volcano plot thumbnail out of sync (#1299)

* fix for thumnails not rendering

* replace mutating state with better check of filters

* Allow html formatting in search page header

* Enable override for GenesByEdaSubset and set question page heading
dynamically.

* use more specific query name

* Use alphabetic ordering when displaying a flattened list of eda entities (#1323)

* only order variable tree entities alphabetically (#1324)

* Add annotations to plotly plots (#1321)

* added plot annotations functionality

* improve scatter annotation story

* added histogram annotation story

* introduce VEuPathDBAnnotation type

* fix annotation types in histogram

* update query name

* use dynamic import for plotly, to keep it out of the main bundle

* replace "EdaSubsetting" with "EdaSubset"

* Revert to injecting script and link tags in document head

* rename component

* Add custom formatter for stepDetails

* Handle empty filters in param value formatter

---------

Co-authored-by: aurreco-uga <aurreco@uga.edu>
Co-authored-by: Cristina Aurrecoechea <aurreco@palm.penn.apidb.org>
Co-authored-by: Ann Sizemore Blevins <asizemore@users.noreply.github.com>
dmfalke added a commit that referenced this pull request Feb 24, 2025
* checkpoint

* Add type annotations to remove inferred `any` type.

* Allow an analysis descriptor to be provided to `useAnalysis`

* Only update state if the next param value is different than the previous
param value

* Extract useAnalysisState to allow external state tracking of analysis object

* Use useAnalysisState, add counts, etc

* Add stubbed question page with custom name

* Allow hiding starred variable feature

* fix typo

* Use global memoization

* Encapsulate creation of eda api clients

* Adhere to lastest "api" for GenesByEdaSubset

* Stub in eda scatterplot for phenotype dataset

* Allow html formatting in search page header

* Enable override for GenesByEdaSubset and set question page heading
dynamically.

* use more specific query name

* update query name

* use dynamic import for plotly, to keep it out of the main bundle

* replace "EdaSubsetting" with "EdaSubset"

* dont wrap sentence

* fix label in user comment upload form

* Fix volcano plot thumbnail out of sync (#1299)

* fix for thumnails not rendering

* replace mutating state with better check of filters

* Allow html formatting in search page header

* Enable override for GenesByEdaSubset and set question page heading
dynamically.

* use more specific query name

* Use alphabetic ordering when displaying a flattened list of eda entities (#1323)

* only order variable tree entities alphabetically (#1324)

* Add annotations to plotly plots (#1321)

* added plot annotations functionality

* improve scatter annotation story

* added histogram annotation story

* introduce VEuPathDBAnnotation type

* fix annotation types in histogram

* update query name

* use dynamic import for plotly, to keep it out of the main bundle

* replace "EdaSubsetting" with "EdaSubset"

* Revert to injecting script and link tags in document head

* Export type

* Expand type to include ReactHTML elements

* Allow className to be overridden

* Add EdaDatasetGraph component

* Use EdaDatasetGraph component with EdaPhenotypeGraphsDataTable

* simplify layout and add warning message for genes not in experiment

* Add parentheses

* Wire up highlightIds

* Highlight graph_ids

* Allow arbitrary variable values to be highlighted

* Specify gene variable values to highlight

---------

Co-authored-by: aurreco-uga <aurreco@uga.edu>
Co-authored-by: Cristina Aurrecoechea <aurreco@palm.penn.apidb.org>
Co-authored-by: Ann Sizemore Blevins <asizemore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0