feat(Gallery): add rtl support #8085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 3561942 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8085 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 404 404
Lines 11559 11605 +46
Branches 3837 3853 +16
=======================================
+ Hits 11043 11087 +44
- Misses 516 518 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/vkui/src/components/CarouselBase/CarouselBase.tsx # packages/vkui/src/components/CarouselBase/helpers.ts
2025-01-20.20.19.40.movНет ли здесь косяка - при изменение |
8000
Сейчас в рантайме к сожалению нельзя менять direction, так как он определяется один раз при первой отрисовке. Поэтому при смене direction нужно перезагрузить страницу |
# Conflicts: # packages/vkui/src/components/Gallery/__image_snapshots__/gallery-android-chromium-dark-1-snap.png # packages/vkui/src/components/Gallery/__image_snapshots__/gallery-android-chromium-light-1-snap.png # packages/vkui/src/components/Gallery/__image_snapshots__/gallery-vkcom-chromium-dark-1-snap.png # packages/vkui/src/components/Gallery/__image_snapshots__/gallery-vkcom-chromium-light-1-snap.png
inomdzhon
reviewed
Feb 11, 2025
There was a problem hiding this comment.
По аналогии с revertRtlValue, не думал создать следующие функции?
const isBigger = (a: number, b: number, isRtl: boolean) => isRtl ? a < b : a > b;
const isBiggerOrEqual = (a: number, b: number, isRtl: boolean) => isRtl ? a <= b : a >= b;
const isLowest = (a: number, b: number, isRtl: boolean) => isRtl ? a > b : a < b;
const isLowestOrEqual = (a: number, b: number, isRtl: boolean) => isRtl ? a >= b : a <= b;и далее
- const fromLastToFirst = isRtl
- ? shiftXCurrentRef.current >= snaps[snaps.length - 1]
- : shiftXCurrentRef.current <= snaps[snaps.length - 1];
+ const from
8000
LastToFirst = isLowestOrEqual(shiftXCurrentRef.current, snaps[snaps.length - 1], isRtl);- const isStartShiftX = isRtl ? shiftXCurrentRef.current <= 0 : shiftXCurrentRef.current >= 0;
+ const isStartShiftX = isBiggerOrEqual(shiftXCurrentRef.current, 0, isRtl);- const moreThanMax = (isRtl && indent < localMax) || (!isRtl && indent > localMax);
- if (moreThanMax) {
+ if (isBigger(indent, localMax, isRtl)) {- const direction = isRtl ? (currentShiftXDelta > 0 ? 1 : -1) : currentShiftXDelta < 0 ? 1 : -1;
+ const direction = isBigger(currentShiftXDelta, 0, isRtl) ? 1 : -1;
inomdzhon
reviewed
Feb 11, 2025
inomdzhon
approved these changes
Feb 11, 2025
| ✅ v7.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас компонента
Galleryне поддерживает отображение в rtl режиме. Нужно добавить поддержку этого режимаИзменения
rtlrtlrtlRelease notes
Улучшения
rtl