8000 feat(Switch): fix rtl view by EldarMuhamethanov · Pull Request #8104 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(Switch): fix rtl view #8104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat(Switch): fix rtl view #8104

merged 3 commits into from
Dec 20, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor
  • e2e-тесты
  • Release notes

Описание

Сейчас компонент Switch в rtl отображается некорректно

Изменения

  • Доработал отображение компонента в rtl режиме
  • Добавил скриншоты

Release notes

Улучшения

  • Switch: Добавлена поддержка компонента в rtl

@EldarMuhamethanov EldarMuhamethanov added this to the v7.2.0 milestone Dec 18, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 18, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 18, 2024 13:59
@codesandbox-ci CodeSandbox CI
Copy link
codesandbox-ci bot commented Dec 18, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Dec 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 389.05 KB (+0.02% 🔺)
JS (gzip) 118.06 KB (+0.02% 🔺)
JS (brotli) 97.23 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.82 KB (+0.09% 🔺)
CSS (gzip) 42.32 KB (+0.08% 🔺)
CSS (brotli) 33.7 KB (-0.04% 🔽)

SevereCloud
SevereCloud previously approved these changes Dec 18, 2024
View reviewed changes
inomdzhon
inomdzhon approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor
@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

@codecov Codecov
Copy link
codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (b5f950e) to head (ad28871).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8104   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11326    11332    +6     
  Branches     3731     3733    +2     
=======================================
+ Hits        10822    10828    +6     
  Misses        504      504
Flag Coverage Δ
unittests 95.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit ad28871

@EldarMuhamethanov EldarMuhamethanov merged commit c059b04 into master Dec 20, 2024
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/Switch branch December 20, 2024 14:28
@vkcom-publisher
Copy link
Contributor
✅ v7.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:switch type:feature
Projects
VKUI
Archived in project
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EldarMuhamethanov @vkcom-publisher @inomdzhon @SevereCloud
0