8000 feat(CellButtonGroup): add component by BlackySoul · Pull Request #8325 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(CellButtonGroup): add component #8325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

feat(CellButtonGroup): add component #8325

merged 1 commit into from
Mar 5, 2025

Conversation

BlackySoul
Copy link
Contributor
@BlackySoul BlackySoul commented Mar 4, 2025 •
edited by inomdzhon
Loading
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Создаем компонент для группировки

UPD

Release notes

Новые компоненты

  • CellButtonGroup: компонент для группировки CellButton

< 8000 /include-fragment>
@BlackySoul BlackySoul requested a review from a team as a code owner March 4, 2025 08:51
@BlackySoul BlackySoul linked an issue Mar 4, 2025 that may be closed by this pull request
[Feature][CellButton]: Возможность добавления сепаратора между кнопками #6360
Closed
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size
JS 396.4 KB (0%)
JS (gzip) 120.39 KB (0%)
JS (brotli) 99.02 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.65 KB (0%)
CSS (gzip) 43.17 KB (0%)
CSS (brotli) 34.43 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link
codesandbox-ci bot commented Mar 4, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 4, 2025

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 4, 2025

👀 Docs deployed

Commit 7bedb9f

@codecov Codecov
Copy link
codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (de20a81) to head (7bedb9f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...src/components/CellButtonGroup/CellButtonGroup.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8325      +/-   ##
==========================================
- Coverage   95.46%   95.44%   -0.02%     
==========================================
  Files         406      407       +1     
  Lines       11610    11617       +7     
  Branches     3844     3845       +1     
==========================================
+ Hits        11083    11088       +5     
- Misses        527      529       +2
Flag Coverage Δ
unittests 95.44% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk
Copy link
Contributor

Классно!

Как-то не всегда сепаратор визуально стоит по центру:
Screenshot 2025-03-04 at 11 57 34

Это вариант нормы?

@BlackySoul
Copy link
Contributor Author

Классно!

Как-то не всегда сепаратор визуально стоит по центру:
Это вариант нормы?

Ну с точки зрения цифр всё ровно х)
У дизайна ревью запрошу

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor
@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

EldarMuhamethanov
EldarMuhamethanov approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor
@EldarMuhamethanov EldarMuhamethanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 003e306 into master Mar 5, 2025
27 of 29 checks passed
@BlackySoul BlackySoul deleted the blackysoul/6360/add_cellbuttongroup branch March 5, 2025 07:12
@BlackySoul BlackySoul mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qurle qurle qurle approved these changes

@EldarMuhamethanov EldarMuhamethanov EldarMuhamethanov approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4498
Development

Successfully merging this pull request may close these issues.

[Feature][CellButton]: Возможность добавления сепаратора между кнопками
4 participants
@BlackySoul @andrey-medvedev-vk @qurle @EldarMuhamethanov
0