8000 fix(ModalPage, ModalCard): fix id warn by BlackySoul · Pull Request #8406 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ModalPage, ModalCard): fix id warn #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

fix(ModalPage, ModalCard): fix id warn #8406

merged 3 commits into from
Mar 28, 2025

Conversation

BlackySoul
Copy link
Contributor
  • Release notes

Описание

Мы ошибочно генерируем предупреждение об отсутствующем id/nav для ModalPage/ModalCard в случае, когда они рендерятся без ModalRoot.

Release notes

Исправления

  • ModalPage: исправлено предупреждение об отсутствующем id/nav при использовании вне ModalRoot

  • ModalCard: исправлено предупреждение об отсутствующем id/nav при использовании вне ModalRoot

@BlackySoul BlackySoul added this to the v7.2.1 milestone Mar 27, 2025
@BlackySoul BlackySoul self-assigned this Mar 27, 2025
@BlackySoul BlackySoul requested a review from a team as a code owner March 27, 2025 11:19
@BlackySoul BlackySoul added this to VKUI Mar 27, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 27, 2025
@codesandbox-ci CodeSandbox CI
Copy link
codesandbox-ci bot commented Mar 27, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 27, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 405.63 KB (-0.01% 🔽)
JS (gzip) 120.48 KB (+0.01% 🔺)
JS (brotli) 99.06 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.95 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.47 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 27, 2025 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 27, 2025 •
edited
Loading

👀 Docs deployed

Commit e26f58a

@BlackySoul BlackySoul moved this to 👀 In Review in VKUI Mar 28, 2025
@BlackySoul BlackySoul merged commit 13bebaf into master Mar 28, 2025
27 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_modal_id_warn branch March 28, 2025 16:22
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Mar 28, 2025
vkcom-publisher pushed a commit that referenced this pull request Mar 28, 2025
@BlackySoul @actions-user
fix(ModalPage, ModalCard): fix id warn (#8406)
ca35f68 
* fix(ModalCard): id not required

* fix(ModalPage) id not required

* fix(ModalPage, ModalCard): move is check
@vkcom-publisher
Copy link
Contributor
✅ v7.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees

@BlackySoul BlackySoul

Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
VKUI
Archived in project
Milestone
v7.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@BlackySoul @vkcom-publisher @inomdzhon @andrey-medvedev-vk
0