8000 feat: do not rewrite user props by BlackySoul · Pull Request #8418 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: do not rewrite user props #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

feat: do not rewrite user props #8418

merged 1 commit into from
Mar 31, 2025

Conversation

BlackySoul
Copy link
Contributor
  • Release notes

Описание

Сейчас некоторые компоненты перезатирают переданные во внутренний компонент Tappable свойства . Отдаём приоритет пользовательским свойствам (так работает подавляющее большинство компонентов).

Release notes

Улучшения

  • все компоненты теперь отдают приоритет пользовательским Tappable-свойствам

@BlackySoul BlackySoul added this to the v7.3.0 milestone Mar 31, 2025
@BlackySoul BlackySoul self-assigned this Mar 31, 2025
@BlackySoul BlackySoul requested a review from a team as a code owner March 31, 2025 09:07
@BlackySoul BlackySoul added this to VKUI Mar 31, 2025
@BlackySoul BlackySoul moved this to 👀 In Review in VKUI Mar 31, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 31, 2025
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@BlackySoul BlackySoul changed the title fix: do not rewrite user props feat: do not rewrite user props Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 405.54 KB (-0.03% 🔽)
JS (gzip) 120.43 KB (-0.05% 🔽)
JS (brotli) 98.96 KB (-0.1% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.95 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.47 KB (0%)

@BlackySoul BlackySoul removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit 45c9fea

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor
@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@BlackySoul BlackySoul merged commit 8e2e725 into master Mar 31, 2025
27 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_tappable_props branch March 31, 2025 11:58
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees

@BlackySoul BlackySoul

Labels
None yet
Projects
VKUI
Archived in project
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BlackySoul @SevereCloud @andrey-medvedev-vk
0