8000 fix(ChipsSelect,ChipsInput): fix remove option with number value by EldarMuhamethanov · Pull Request #8450 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ChipsSelect,ChipsInput): fix remove option with number value #8450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix(ChipsSelect,ChipsInput): fix remove option with number value #8450

merged 1 commit into from
Apr 10, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor
@EldarMuhamethanov EldarMuhamethanov commented Apr 9, 2025 •
edited
Loading
  • Unit-тесты
  • Release notes

Описание

Если у option свойство value является числом, то на этот option не срабатывает удаление через кнопку Backspace/Delete.

Изменения

  • Добавил для чипа атрибут data-value-type - со значениями number/string, чтобы можно было определить тип и сделать нужное преобразование

Release notes

Исправления

  • ChipsSelect: Поправлен баг с удалением чипа, если у него в value было значение типа number

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner April 9, 2025 12:16
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 9, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 9, 2025

size-limit report 📦

Path Size
JS 403.25 KB (+0.02% 🔺)
JS (gzip) 119.87 KB (+0.02% 🔺)
JS (brotli) 98.48 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.95 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.49 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link
codesandbox-ci bot commented Apr 9, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 9, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 9, 2025

👀 Docs deployed

Commit 7aac3de

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor
@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit b31a60c into master Apr 10, 2025
27 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8434/fix-chips-remove branch April 10, 2025 13:11
vkcom-publisher pushed a commit that referenced this pull request Apr 10, 2025
@EldarMuhamethanov @actions-user
fix(ChipsSelect,ChipsInput): fix remove option with number value (#8450)
26017d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees
No one assigned
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Milestone
No milestone
3 participants
@EldarMuhamethanov @SevereCloud @andrey-medvedev-vk
0