8000 fix(useModalRootContext): add activeModal by SevereCloud · Pull Request #8481 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(useModalRootContext): add activeModal #8481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SevereCloud
Copy link
Contributor
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

По документации useModalRootContext должен возвращать activeModal

Release notes

Исправления

@SevereCloud SevereCloud requested a review from a team as a code owner April 17, 2025 13:13
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 17, 2025
@SevereCloud SevereCloud self-assigned this Apr 17, 2025
@SevereCloud SevereCloud added this to VKUI Apr 17, 2025
Copy link
Contributor

size-limit report 📦

Path Size
JS 407.71 KB (+0.01% 🔺)
JS (gzip) 120.87 KB (+0.01% 🔺)
JS (brotli) 98.94 KB (+0.15% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.97 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.51 KB (0%)

@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Apr 17, 2025
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 7d98d6f

Copy link
codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (c0c6650) to head (7d98d6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8481   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         413      413           
  Lines       11762    11762           
  Branches     3897     3897           
=======================================
  Hits        11242    11242           
  Misses        520      520           
Flag Coverage Δ
unittests 95.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit 281d692 into master Apr 17, 2025
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/useModalRootContext/add-activeModal branch April 17, 2025 13:52
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Apr 17, 2025
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 7.2-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 7.2-stable, выполните следующие действия:

  1. Создайте новую ветку от 7.2-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 7.2-stable
git checkout -b patch/pr8481 origin/7.2-stable

git cherry-pick --no-commit 281d692483c80bb86231b2d0485d03f9cb24a2b3
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 7.2-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr8481
gh pr create --base 7.2-stable --title "patch: pr8481" --body "- patch #8481"

@SevereCloud SevereCloud added this to the v7.2.1 milestone Apr 17, 2025
@SevereCloud SevereCloud mentioned this pull request Apr 17, 2025
@vkcom-publisher
Copy link
Contributor
v7.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants
0