8000 fix(Progress): appearance token type by SevereCloud · Pull Request #8504 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(Progress): appearance token type #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

SevereCloud
Copy link
Contributor
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Исправляем тип для покраски токеном

Release notes

Исправления

  • Progress: исправлен тип поля appearance для использования с токеном

@SevereCloud SevereCloud requested a review from a team as a code owner April 21, 2025 15:13
@SevereCloud SevereCloud self-assigned this Apr 21, 2025
@SevereCloud SevereCloud added this to the v7.2.2 milestone Apr 21, 2025
@SevereCloud SevereCloud added this to VKUI Apr 21, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Apr 21, 2025
Copy link
Contributor

size-limit report 📦

Path Size
JS 407.84 KB (0%)
JS (gzip) 120.92 KB (0%)
JS (brotli) 99 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.97 KB (0%)
CSS (gzip) 43.23 KB (0%)
CSS (brotli) 34.51 KB (0%)

Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8504/7e5cc1d1beda18992823327cdc6623423e185596/pkg/@vkontakte/vkui/_pkg.tgz

Commit 7e5cc1d

Copy link
codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (9c3a960) to head (7e5cc1d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8504   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         414      414           
  Lines       11770    11770           
  Branches     3899     3899           
=======================================
  Hits        11249    11249           
  Misses        521      521           
Flag Coverage Δ
unittests 95.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit cb94fb1 into master Apr 22, 2025
18 of 20 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Progress/appearance-token-type branch April 22, 2025 07:18
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Apr 22, 2025
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 7.2-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 7.2-stable, выполните следующие действия:

  1. Создайте новую ветку от 7.2-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 7.2-stable
git checkout -b patch/pr8504 origin/7.2-stable

git cherry-pick --no-commit cb94fb1c13aa6c8ab7bcaa35561297f839698b8c
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 7.2-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr8504
gh pr create --base 7.2-stable --title "patch: pr8504" --body "- patch #8504"

@SevereCloud SevereCloud mentioned this pull request Apr 22, 2025
@inomdzhon inomdzhon modified the milestones: v7.2.2, v7.3.0 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants
0