fix(Search): fix long placeholder view #8559
Open
+135
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8559/ce66c49178a45f0fe0e533361d7abc5b73e41f90/pkg/@vkontakte/vkui/_pkg.tgzCommit ce66c49 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8559 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 414 414
Lines 11900 11915 +15
Branches 3939 3941 +2
=======================================
+ Hits 11409 11424 +15
Misses 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Заметил вот такую штуку 2025-05-12.18.28.03.mov |
Не совсем понял о чем ты? Про то, что плейсхолдер не обрезается, когда фокус в поле? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholderоберазается скрытыми кнопками справа #8538Описание
Сейчас плейсхолдер обрезается не у края компонента, из-за того что справа всегда зарезервировано место под контролы(кнопка очистки и кастомная иконка). Нужно, чтобы эти контролы, когда не отображаются удалялись из dom, тогда плейсхолдер будет растягиваться на всю ширину
Изменения
useCSSKeyframesAnimationControllerдля отслеживания состояния анимацийRelease notes
Исправления