fix(FormLayoutGroup): add disabled to removable #8550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https:
8000
//vkui-screenshot.hb.bizmrg.com/pull/8550/b439fb9e58e5553878a0417d77a240f090679b09/pkg/@vkontakte/vkui/_pkg.tgzCommit b439fb9 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8550 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 414 414
Lines 11900 11900
Branches 3939 3939
=======================================
Hits 11408 11408
Misses 492 492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
approved these changes
May 12, 2025
inomdzhon
approved these changes
May 12, 2025
vkcom-publisher
pushed a commit
that referenced
this pull request
May 12, 2025
| ✅ v7.3.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
disabledне прокидывался вremovableкомпонент, позволяем это делать (по аналогии сCellкомпонентов).Ранее обсуждали с дизайном, что этот проп может быть не нужен, но
disabledна компонентеfieldset(именно он рендерится по умолчанию) имеет значение дляa11y.Release notes
Исправления
disabledтеперь влияет на режимremovable