8000 fix(CustomSelect): fix readonly mode by EldarMuhamethanov · Pull Request #8590 · VKCOM/VKUI · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(CustomSelect): fix readonly mode #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

fix(CustomSelect): fix readonly mode #8590

merged 1 commit into from
May 20, 2025

Conversation

EldarMuhamethanov
Copy link
Contributor
  • Release notes

Описание

Сейчас при прокидывании в CustomSelect свойство readonly поле все еще можно изменять, открывать дропдаун и тд. Нужно поправить

Изменения

  • Сделал корректное прокидывание readOnly свойства до input
  • Также при прокидывании readOnly отключил обработку действий, которые могли бы открыть дропдаун
  • Решил, что при прокидывании readOnly не должны показывать иконки открытия(шеврон) и кнопка удаления.

Release notes

Исправления

  • CustomSelect: Исправлено поведение компонента при прокидывании readOnly

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner May 20, 2025 12:19
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 408.91 KB (+0.02% 🔺)
JS (gzip) 121.82 KB (+0.02% 🔺)
JS (brotli) 99.95 KB (-0.08% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.12 KB (0%)
CSS (gzip) 43.25 KB (0%)
CSS (brotli) 34.51 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@codecov Codecov
Copy link
codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable 8000 lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (af5a4e0) to head (ebdcfbf).
Report is 20 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8590   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         416      416           
  Lines       11932    11936    +4     
  Branches     3945     3948    +3     
=======================================
+ Hits        11441    11445    +4     
  Misses        491      491
Flag Coverage Δ
unittests 95.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8590/ebdcfbfc8afa60c9b3615d3332acd8a07d5596ba/pkg/@vkontakte/vkui/_pkg.tgz

Commit ebdcfbf

inomdzhon
inomdzhon approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а ты хочешь с этим в v7.3.6?

@EldarMuhamethanov
Copy link
Contributor Author

а ты хочешь с этим в v7.3.6?

Вообще не собирался, можно отложить на потом

@inomdzhon
Copy link
Contributor

а ты хочешь с этим в v7.3.6?

Вообще не собирался, можно отложить на потом

вообще, раз это фикс, то можно и в v7.3.6 сразу

@EldarMuhamethanov EldarMuhamethanov merged commit 50cc480 into master May 20, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamthanov/8564/readonly-custom-select branch May 20, 2025 12:31
vkcom-publisher pushed a commit that referenced this pull request May 20, 2025
@EldarMuhamethanov @actions-user
fix(CustomSelect): fix readonly mode (#8590)
05a7dc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees
No one assigned
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Поддержать readOnly для CustomSelect
3 participants
@EldarMuhamethanov @inomdzhon @SevereCloud
0