10000 Trailing comma for function use and parameter lists by mkornaukhov03 · Pull Request #971 · VKCOM/kphp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trailing comma for function use and parameter lists #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Trailing comma for function use and parameter lists #971

wants to merge 4 commits into from

Conversation

mkornaukhov03
Copy link
Contributor

See #664
Just change compare branch

tolk-vm
tolk-vm reviewed Mar 6, 2024
View reviewed changes
compiler/gentree.cpp
@@ -97,6 +99,9 @@ VertexPtr GenTree::get_foreach_value() {
}

VertexAdaptor<op_var> GenTree::get_function_use_var_name_ref() {
if (cur->type() == tok_clpar) { // for trailing comma
return {};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange, because get_func_param() and other list-item parsing function don't handle ')' separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolk-vm tolk-vm tolk-vm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkornaukhov03 @tolk-vm
0