Python APIとJava APIのCargo.tomlからtest_utilへの依存を外す #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Oct 26, 2023
| @@ -274,7 +274,7 @@ jobs: | |||
| - run: | | |||
| pip install --upgrade poetry | |||
| poetry install --with dev --with test | |||
| - run: cargo build -p voicevox_core_c_api -vv | |||
| - run: cargo build -p test_util -vv # build scriptにより/crates/test_util/data/の生成 | |||
There was a problem hiding this comment.
メモ: #659 (comment)
WindowsかmacOSでのMaturin関係だったと思う...多分。少なくともこれで動くし問題無いはず。
sevenc-nanashi
approved these changes
Oct 26, 2023
Hiroshiba
approved these changes
Oct 26, 2023
ですね。この方が(現状でできる範囲だと)混乱を避けれそうかと。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
pytestとgradle testは現在/crates/test_util/dataのファイルに依存しています。それが自動的にビルドされるよう、Python/Java APIのCargo.tomlに依存としてtest_utilクレートが入っているのですが、この指定はほとんど意味を成していません。なぜならPython/Java APIを単体で「ビルド」する際には結局test_utilを単体で
cargo buildしなければならなくなるからです。このPRではその指定を削除してしまいます。(その代わり、Python APIの方のCIには
cargo build -p test_utilの指定を入れます)経緯: #659 (comment)
関連 Issue
Closes #659.
その他