8000 ccを1.0.73から1.0.83へupdate by nekomimimi · Pull Request #720 · VOICEVOX/voicevox_core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ccを1.0.73から1.0.83へupdate #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2023
Merged

ccを1.0.73から1.0.83へupdate #720

merged 1 commit into from
Dec 30, 2023

Conversation

nekomimimi
Copy link
Contributor
@nekomimimi nekomimimi commented Dec 29, 2023

内容

clang++ ver 15.0.0のiOSビルドできるようにした。

warning: clang: error: unknown argument: '-arch arm64'
でコンパイルできない件の修正。

Cコンパイラのccを1.0.73から1.0.83へ上げた。

関連 Issue

ref #524

その他

1.0.79であれば上記エラーはなくなりますが、最新の1.0.83としました。
コンパイラのバージョンアップのためマージの際は影響を確認ください。
(今のワークアラウンドのclangのバージョンを下げてのコンパイルのほうに影響があれば少し心配かも)

Copy link
Member
@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qryxip qryxip requested a review from Hiroshiba December 30, 2023 00:42
Copy link
Member
@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

丁寧なプルリクエストありがとうございます!!

@Hiroshiba Hiroshiba merged commit f184995 into VOICEVOX:main Dec 30, 2023
@nekomimimi nekomimimi deleted the cc_update_1_0_83 branch December 30, 2023 07:32
@nekomimimi nekomimimi restored the cc_update_1_0_83 branch December 30, 2023 11:26
@nekomimimi nekomimimi deleted the cc_update_1_0_83 branch December 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0