Delay flow error until the flow is completed. #4210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevously the flow state was set to error as soon as a log was issued at level ERROR however the query continued running until the end. This caused the GUI to disable the cancel button so it was impossible to cancel the flow. This PR Keeps the flow at the IN_PROGRESS state until completion while tagging the error message in the flow. This allows the flow to be cancelled after the error by the GUI. After completion the flow will be switched to the ERROR state. Also: 1. Fix Registry accessor parsing of MULTI_SZ fields. 2. Fix Generic.Client.Profile artifact 3. Refactor tests to use the global mock clock
scudette
added a commit
that referenced
this pull request
May 20, 2025
Prevously the flow state was set to error as soon as a log was issued at level ERROR however the query continued running until the end. This caused the GUI to disable the cancel button so it was impossible to cancel the flow. This PR Keeps the flow at the IN_PROGRESS state until completion while tagging the error message in the flow. This allows the flow to be cancelled after the error by the GUI. After completion the flow will be switched to the ERROR state. Also: 1. Fix Registry accessor parsing of MULTI_SZ fields. 2. Fix Generic.Client.Profile artifact 3. Refactor tests to use the global mock clock
scudette
added a commit
that referenced
this pull request
May 20, 2025
Prevously the flow state was set to error as soon as a log was issued at level ERROR however the query continued running until the end. This caused the GUI to disable the cancel button so it was impossible to cancel the flow. This PR Keeps the flow at the IN_PROGRESS state until completion while tagging the error message in the flow. This allows the flow to be cancelled after the error by the GUI. After completion the flow will be switched to the ERROR state. Also: 1. Fix Registry accessor parsing of MULTI_SZ fields. 2. Fix Generic.Client.Profile artifact 3. Refactor tests to use the global mock clock
scudette
added a commit
that referenced
this pull request
May 20, 2025
Prevously the flow state was set to error as soon as a log was issued at level ERROR however the query continued running until the end. This caused the GUI to disable the cancel button so it was impossible to cancel the flow. This PR Keeps the flow at the IN_PROGRESS state until completion while tagging the error message in the flow. This allows the flow to be cancelled after the error by the GUI. After completion the flow will be switched to the ERROR state. Also: 1. Fix Registry accessor parsing of MULTI_SZ fields. 2. Fix Generic.Client.Profile artifact 3. Refactor tests to use the global mock clock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevously the flow state was set to error as soon as a log was issued at level ERROR however the query continued running until the end. This caused the GUI to disable the cancel button so it was impossible to cancel the flow.
This PR Keeps the flow at the IN_PROGRESS state until completion while tagging the error message in the flow. This allows the flow to be cancelled after the error by the GUI. After completion the flow will be switched to the ERROR state.
Also: