Bugfix: FetchBinary now works with multiple serve URLs. #4315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the FetchBinary artifact that enables using external tools, used only the first URL available from the Client.server_urls. This broke tools when several URLs were used for failover. This changle allows the server to specify all URLs as possible URLs to download tools from making it work in failover situations. Also: - Config generate wizard did not properly ask dyndns questions. - Fixed notebook upload GUI
Snyk has created this PR to upgrade webpack from 5.99.8 to 5.99.9. See this package in npm: webpack See this project in Snyk: https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade moment-timezone from 0.5.48 to 0.6.0. See this package in npm: moment-timezone See this project in Snyk: https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade humanize-duration from 3.32.1 to 3.32.2. See this package in npm: humanize-duration See this project in Snyk: https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade dompurify from 3.2.5 to 3.2.6. See this package in npm: dompurify See this project in Snyk: https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @babel/runtime from 7.27.1 to 7.27.4. See this package in npm: @babel/runtime See this project in Snyk: https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr
|
|
scudette
added a commit
that referenced
this pull request
Jul 2, 2025
Previously the FetchBinary artifact that enables using external tools, used only the first URL available from the Client.server_urls. This broke tools when several URLs were used for failover. This changle allows the server to specify all URLs as possible URLs to download tools from making it work in failover situations. Also: - Config generate wizard did not properly ask dyndns questions. - Fixed notebook upload GUI --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io>
scudette
added a commit
that referenced
this pull request
Jul 2, 2025
Previously the FetchBinary artifact that enables using external tools, used only the first URL available from the Client.server_urls. This broke tools when several URLs were used for failover. This changle allows the server to specify all URLs as possible URLs to download tools from making it work in failover situations. Also: - Config generate wizard did not properly ask dyndns questions. - Fixed notebook upload GUI --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the FetchBinary artifact that enables using external tools, used only the first URL available from the Client.server_urls. This broke tools when several URLs were used for failover.
This changle allows the server to specify all URLs as possible URLs to download tools from making it work in failover situations.
Also: