8000 Fix platform flash on download page by ZirixCZ · Pull Request #35 · Vencord/vencord.dev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix platform flash on download page #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix platform flash on download page #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2be3ea5
Refactor platform selection logic in download page
ZirixCZ Dec 15, 2023
8fbccae
Render empty container before a platform is chosen
ZirixCZ Dec 15, 2023
e233331
Set the initial platform value in a cookie and pre-render the page
ZirixCZ Dec 16, 2023
ac558fd
remove console log
ZirixCZ Dec 16, 2023
ab733df
Merge branch 'main' into fix-download-flash
ZirixCZ Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/components/pages/download/WindowsTabPlaceholder.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
import WindowsTab from "./WindowsTab.astro";
---

<div>
<WindowsTab />
</div>

<style>
div {
visibility: hidden;
}
</style>
43 changes: 29 additions & 14 deletions src/components/pages/download/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,43 @@
<script lang="ts">
import { onMount } from "svelte";
import { writable } from "svelte/store";
import { fade } from "svelte/transition";

import { IS_SERVER } from "scripts/constants";
export let initialPlatform;

const options = ["Windows", "Linux", "Mac", "Browser"] as const;

const parsePlatform = (platform: string): (typeof options)[number] => {
if (platform.includes("linux")) return "Linux";
if (platform.includes("mac")) return "Mac";
if (platform.includes("win")) return "Windows";
return "Browser";
};

const accents: { [option in (typeof options)[number]]: string } = {
Windows: "Blue",
Linux: "Green",
Mac: "Yellow",
Browser: "Orange",
};

const initialValue = IS_SERVER
? "Windows"
: (() => {
const stored = localStorage.platform;
if (stored && options.includes(stored)) return stored;
const selected = writable<string | null>(
initialPlatform ? parsePlatform(initialPlatform.toLowerCase()) : null
);

const platform = navigator.platform.toLowerCase();
if (platform.includes("linux")) return "Linux";
if (platform.includes("mac")) return "Mac";
return "Windows";
})();
onMount(() => {
const getInitialPlatform = (): string => {
const platform = navigator.platform.toLowerCase();
return parsePlatform(platform);
};

const selected = writable(initialValue);
if (!IS_SERVER) selected.subscribe(v => (localStorage.platform = v));
if (!$selected) {
selected.set(getInitialPlatform());
}
selected.subscribe(v => {
document.cookie = `platform=${v}; path=/; max-age=2147483647`;
});
});
</script>

<div class="container">
Expand All @@ -50,7 +61,11 @@

<section>
<!-- grrr <slot> name cannot be dynamic -->
{#if $selected === "Windows"}
{#if !$selected}
<div in:fade={{ duration: 150 }}>
<slot name="windowsTabPlaceholder" />
</div>
{:else if $selected === "Windows"}
<div in:fade={{ duration: 150 }}>
<slot name="windowsTab" />
</div>
Expand Down
8 changes: 7 additions & 1 deletion src/pages/download.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,22 @@ import BrowserTab from "components/pages/download/BrowserTab.astro";
import LinuxTab from "components/pages/download/LinuxTab.astro";
import MacTab from "components/pages/download/MacTab.astro";
import WindowsTab from "components/pages/download/WindowsTab.astro";
import WindowsTabPlaceholder from "components/pages/download/WindowsTabPlaceholder.astro";
import DownloadTabs from "components/pages/download/index.svelte";

const platform = Astro.cookies.get('platform')?.value;

---


<Layout
title="Download Vencord"
description="Download Vencord for Desktop or your favourite Browser"
breadcrumbs={[["Download", "/download"]]}
>
<DownloadTabs client:load>
<DownloadTabs client:load initialPlatform={platform}>
<h1 class="p-page-title" slot="title">Download Vencord</h1>
<WindowsTabPlaceholder slot="windowsTabPlaceholder" />
<WindowsTab slot="windowsTab" />
<LinuxTab slot="linuxTab" />
<MacTab slot="macTab" />
Expand Down
14 changes: 14 additions & 0 deletions src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,20 @@ if (features.length % 3 !== 0)
</section>
</Layout>

<script>
function setPlatformCookie() {
if (document.cookie.includes("platform")) {
return;
}

document.cookie = `platform=${navigator.platform}; path=/; max-age=2147483647`;
}

if (typeof window !== "undefined") {
setPlatformCookie();
}
</script>

<style>
.tagline {
display: flex;
Expand Down
0