Fix function policies for Athena outputs in S3 #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with the S3 permissions on the Analytics functions which caused Athena to fail in some circumstances:
By default, amplify's storage access setting from the cli only allows
s3:ListBucket,s3:PutObject, ands3:GetObject, but Amplify seems to need more to work properly in all cases. To fix this, I added to the functions' custom policies to allow the necessary S3 permissions.Added this policy
This policy has been added to all analytics policies (anything using Athena):
{ "Effect": "Allow", "Action": [ "s3:GetBucketLocation", "s3:GetObject", "s3:ListBucket", "s3:ListBucketMultipartUploads", "s3:ListMultipartUploadParts", "s3:AbortMultipartUploads", "s3:CreateBucket", "s3:PutObject" ], "Resource": [ { "Fn::Join": [ "", [ "arn:aws:s3:::", { "Ref": "storagememesrcGeneratedImagesBucketName" } ] ] }, { "Fn::Join": [ "", [ "arn:aws:s3:::", { "Ref": "storagememesrcGeneratedImagesBucketName" }, "/*" ] ] } ] }