8000 Adjust nav, header, and routes by davisengeler · Pull Request #104 · Vibe-House-LLC/memeSRC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjust nav, header, and routes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2023
Merged

Adjust nav, header, and routes #104

merged 5 commits into from
May 30, 2023

Conversation

davisengeler
Copy link
Contributor
@davisengeler davisengeler commented May 28, 2023 •
edited
Loading

Description

This PR contains a few changes and finishes a Todo item from #103:

  • Wrap other existing user-facing pages in <DashboardLayout>
  • Migrate logo display to the Nav component
  • Add show/hide animation on the homepage.

Background

Todo

  • Add top padding to existing content
  • Remove <CheckAuth> requirement

Demos

Wrapped existing user-facing pages

image

Logo show/hide animation on homepage

trimmed.mov

@davisengeler davisengeler added the enhancement New feature or request label May 28, 2023
@davisengeler davisengeler self-assigned this May 28, 2023
@davisengeler davisengeler changed the title Nav and header adjustments Adjust nav, header, and routes May 28, 2023
AustinWoodard
AustinWoodard approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator
@AustinWoodard AustinWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davisengeler davisengeler merged commit 3a28619 into dev May 30, 2023
@davisengeler davisengeler deleted the nav-adjustments branch May 30, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinWoodard AustinWoodard AustinWoodard approved these changes

Assignees

@davisengeler davisengeler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davisengeler @AustinWoodard
0