Fix return type on Rss::fetch #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc block and return type suggest it's returning an ArticlesCollection but in reality it's returning the output of `parse()`, which is returning an instance of the `FeedInterface`, so any usage of this method just returns an exception.8000
Mulkave
approved these changes
Aug 3, 2020
|
@mattstauffer thanks for pointing that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc block and return type suggest it's returning an ArticlesCollection but in reality it's returning the output of
parse(), which is returning an instance of theFeedInterface, so any usage of this method just returns an exception.Thanks for the great library!