fix: fix the config update for table #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzo4MDYzNjQxMzk6Y29tbWl0OjNmNjYxNjllNGFiNjI4ODQ3YzQwZjc3ZTA4MjQyYzYzZWM3YTlhNTciLCJ0IjoxNzUyNDY3MzEzfQ==--b249b8dcd114070d98ab8561d5be494ba8b8613e9a515d97890899548e2e02fe" data-url="/VisActor/VStory/pull/227/partials/commit_status_icon?oid=3f66169e4ab628847c40f77e08242c63ec7a9a57">
xuefei1313
approved these changes
Jan 20, 2025
| @@ -183,6 +183,9 @@ export class VTableGraphic extends Rect { | |||
| super.setAttribute('x', value.x1); | |||
| super.setAttribute('y', value.y1); | |||
| this.updateVTableGraphicViewBox(value); | |||
| } | |||
| if (key === 'spec') { | |||
| (this._vTable as any).updateOption(value); | |||
There was a problem hiding this comment.
这个要不也用 createOption 处理一下？this._createOption({ spec: value })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🐞 Bugserver case id
💡 Background and solution
fix table option update & row visible runtime
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough