8000 show update info in About command on linux · Pull Request #663 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

show update info in About command on linux #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 11, 2022
Merged

show update info in About command on linux #663

merged 4 commits into from
Mar 11, 2022

Conversation

ghost
Copy link
@ghost ghost commented Feb 18, 2022 •
edited by ghost
Loading

It resolves #543

@ghost ghost marked this pull request as draft February 18, 2022 08:58
@ghost ghost requested review from alexarchambault, lwronski and tpasternak February 18, 2022 09:15
@ghost ghost changed the title added support for update info in About and Version commands on linux show update info in About and Version commands on linux Feb 18, 2022
@ghost ghost marked this pull request as ready for review February 21, 2022 18:11
romanowski
romanowski reviewed Feb 22, 2022
View reviewed changes
Copy link
Member
@romanowski romanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if there is a good way to implement this feature. We need to discuss it on our team meeting.

@ghost ghost force-pushed the cli-version-display branch from f6f075a to 2b5f5f8 Compare February 23, 2022 08:27
@ghost ghost marked this pull request as draft February 23, 2022 09:06
@ghost ghost force-pushed the cli-version-display branch from ecd03f7 to 7e4fc18 Compare February 23, 2022 10:17
@ghost ghost marked this pull request as ready for review February 23, 2022 14:21
This was referenced Feb 23, 2022
Closed
Closed
@ghost ghost requested review from romanowski and lwronski February 24, 2022 09:47
lwronski
lwronski reviewed Feb 24, 2022
View reviewed changes
@ghost ghost force-pushed the cli-version-display branch from 73280ff to 7ea0bc5 Compare February 28, 2022 14:15
@ghost ghost requested a review from lwronski February 28, 2022 14:19
lwronski
lwronski reviewed Mar 1, 2022
View reviewed changes
@ghost ghost requested a review from lwronski March 1, 2022 10:15
@ghost
Copy link
Author
ghost commented Mar 1, 2022

FYI, the conflict with the main branch is caused by the refactoring of the absolute path calculation inside CommandUtils

@ghost ghost force-pushed the cli-version-display branch from f8f7a14 to 51ff306 Compare March 1, 2022 14:21
@ghost
Copy link
Author
ghost commented Mar 2, 2022

@romanowski this is ready to get merged!

@ghost
Copy link
Author
ghost commented Mar 2, 2022

@romanowski the functionality of PR #741 is overlapping this one

lwronski
lwronski reviewed Mar 2, 2022
View reviewed changes
@ghost ghost force-pushed the cli-version-display branch from 51ff306 to e796aa3 Compare March 4, 2022 14:33
@ghost ghost force-pushed the cli-version-display branch from 8fc7b20 to 4684869 Compare March 4, 2022 15:37
@ghost ghost changed the title show update info in About and Version commands on linux show update info in About command on linux Mar 4, 2022
@ghost ghost requested review from alexarchambault and lwronski and removed request for romanowski March 7, 2022 10:52
@lwronski lwronski removed the request for review from alexarchambault March 7, 2022 11:30
@alexarchambault alexarchambault merged commit f08a524 into VirtusLab:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski Awaiting requested review from lwronski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diffucult to understand which version of scala-cli I have or if it is the latest or if I need to update or if I have duplicates on path
3 participants
@romanowski @lwronski @alexarchambault
0