8000 Use logger in console build bloop client by lwronski · Pull Request #713 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use logger in console build bloop client #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

Use logger in console build bloop client #713

merged 1 commit into from
Feb 28, 2022

Conversation

lwronski
Copy link
Contributor

If someone pass -q flag, should cli should not print any log. But out.println every time print the following message:

Compiling project (Scala 3.1.1, JVM)
Compiled project (Scala 3.1.1, JVM)

To fix it, we use logger.message which prints log only if, verbosity if higher then 0.
If -q if pass, the verbosity is set to -1.

@lwronski lwronski linked an issue Feb 28, 2022 that may be closed by this pull request
Quiet flag (-q) doesn't suppress "Compiling..." / "Compiled..." messages #701
Closed
@lwronski lwronski enabled auto-merge (squash) February 28, 2022 11:00
@lwronski lwronski merged commit 16c6fab into VirtusLab:main Feb 28, 2022
romanowski pushed a commit to romanowski/scala-cli that referenced this pull request Mar 10, 2022
@lwronski @romanowski
Use logger in console build bloop client (VirtusLab#713)
e1f1936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quiet flag (-q) doesn't suppress "Compiling..." / "Compiled..." messages
2 participants
@lwronski @alexarchambault
0