8000 Update scalafmt-cli to 3.5.0 by scala-steward · Pull Request #835 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update scalafmt-cli to 3.5.0 #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Update scalafmt-cli to 3.5.0 #835

wants to merge 4 commits into from

Conversation

scala-steward
Copy link
Contributor

Updates org.scalameta:scalafmt-cli from 3.0.8 to 3.5.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-cli" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@scala-steward scala-steward mentioned this pull request Apr 2, 2022
Closed
@lwronski lwronski force-pushed the update/scalafmt-cli-3.5.0 branch from bcf7250 to b7adf39 Compare April 4, 2022 13:28
@lwronski lwronski enabled auto-merge (squash) April 4, 2022 13:28
@lwronski
Copy link
Contributor
lwronski commented Apr 5, 2022

Without version parameter in .scalafmt.conf it throws following error:

error: missing version (current 3.5.0)

So, I added explicitly version parameter to .scalafmt.conf and now it works.

@lwronski lwronski requested a review from alexarchambault April 5, 2022 08:55
@alexarchambault alexarchambault disabled auto-merge April 5, 2022 09:42
@lwronski lwronski disabled auto-merge April 5, 2022 09:48
@lwronski
Copy link
Contributor
lwronski commented Apr 5, 2022 •
edited
Loading

I think, it needs some additional works, because Fmt command also throw the same error:

error: missing version (current 3.5.0)

Scalafmt requires, that users have to declared explicitly scalafmt version, so I added log, that users have to add version parameter to .scalafmt.conf - https://github.com/scalameta/scalafmt/pull/2873/files

@lwronski lwronski force-pushed the update/scalafmt-cli-3.5.0 branch from d8595ea to 7c4e24e Compare April 6, 2022 07:35
@scala-steward
Copy link
Contributor Author

Superseded by #860.

@lwronski lwronski closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

@romanowski romanowski Awaiting requested review from romanowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scala-steward @lwronski @alexarchambault
0