Send the Bloop server output to a file when possible #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9e5d58 to
e909068
Compare
Seems I had hidden those on the JVM, but not in native launchers.
Printing the output of the Bloop server, when available
e5394d6 to
c868eba
Compare
romanowski
approved these changes
Apr 14, 2022
| version.takeWhile(c => c.isDigit || c == '.').split('.') match { | ||
| case Array(IntValue(maj), IntValue(min), IntValue(patch)) => | ||
| import scala.math.Ordering.Implicits._ | ||
| Seq(maj, min, patch) >= Seq(1, 14, 20) |
There was a problem hiding this comment.
I wonder why we do need to check the bloop version if we control the version of bloop ourselves? I think if we see too old version running (e.g. after update of scala-cli) we should restart it with newer version
There was a problem hiding this comment.
That's for if users manually force an earlier version to something else. Earlier Bloop versions can't truncate their output file, so redirecting the output this way would create a file that might grow too big.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs scala-cli/bloop-core#55, included in the upcoming (Scala CLI's) bloop-core
1.4.20.This sends the output of the Bloop server to a file under the user home directory (alongside the socket file,
~/Library/Caches/ScalaCli/bloop/daemon/outputon macOS for example), and adds ascala-cli bloop outputcommand printing that file in the console, so that users can easily have a look at that file.In order for that output file not to grow too big, we pass an option to the Bloop server so that it truncates that file periodically (as soon as it reaches 1 MB, scala-cli/bloop-core#55).