8000 Refactor the usage of default main class override to only apply to on-disk Scripts by Gedochao · Pull Request #943 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor the usage of default main class override to only apply to on-disk Scripts #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2022
Merged

Refactor the usage of default main class override to only apply to on-disk Scripts #943

merged 3 commits into from
Apr 28, 2022

Conversation

Gedochao
Copy link
Contributor

No description provided.

Gedochao added 2 commits April 26, 2022 13:30
@Gedochao
Refactor sources default main class override
bed324e 
- it is only to be used by scripts
- rename relevant fieds to imply the purpose better
@Gedochao
NIT Refactor
38fd674 
  - remove redundant braces
  - apply Scala 3 syntax where applicable
  - remove redundant conversions
  - simplify transformations
  - fill-in missing type declarations
  - explicit annotate @tailrec functions
  - remove redundant regex escapes
@Gedochao Gedochao force-pushed the refactor-main-class-override branch from 0f24625 to 38fd674 Compare April 26, 2022 11:58
@Gedochao Gedochao marked this pull request as draft April 27, 2022 07:00
@Gedochao
Make package command output name fallback to actual compiled main c…
6f680d2 
…lass name if there's no default main class override present
@Gedochao Gedochao force-pushed the refactor-main-class-override branch from 5d46d20 to 6f680d2 Compare April 27, 2022 12:08
@Gedochao Gedochao marked this pull request as ready for review April 27, 2022 12:16
@Gedochao Gedochao merged commit a963ed0 into VirtusLab:main Apr 28, 2022
@Gedochao Gedochao deleted the refactor-main-class-override branch April 28, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @alexarchambault
0