10000 Use Constants.defaultScalaVersion instead of properties scala version by lwronski · Pull Request #955 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use Constants.defaultScalaVersion instead of properties scala version #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

Use Constants.defaultScalaVersion instead of properties scala version #955

merged 1 commit into from
Apr 29, 2022

Conversation

lwronski
Copy link
Contributor

Properties.versionNumberString returns 2.13.8 in Scala 3 - it is described very well in stack-overflow.

To avoid unexpected behavior, we shouldn't use Properties.versionNumberString in ScalaCLI repo after migration to Scala 3.

@lwronski lwronski requested review from romanowski and Gedochao April 29, 2022 08:49
@lwronski lwronski changed the title Use Constants.defaultScalaVersion instead of properties version Use Constants.defaultScalaVersion instead of properties scala version Apr 29, 2022
@lwronski lwronski merged commit 08aa9f2 into VirtusLab:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@Gedochao Gedochao Gedochao approved these changes

@romanowski romanowski Awaiting requested review from romanowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @alexarchambault @Gedochao
0