8000 Suggest zip issue workaround when apparently running into it by alexarchambault · Pull Request #1007 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Suggest zip issue workaround when apparently running into it #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

Suggest zip issue workaround when apparently running into it #1007

merged 1 commit into from
May 16, 2022

Conversation

alexarchambault
Copy link
Contributor

Follow-up of #865. This suggests users to set the right environment variable to disable checking zip CRC32 checksums.

@alexarchambault alexarchambault marked this pull request as ready for review May 11, 2022 13:42
@alexarchambault alexarchambault force-pushed the suggest-zip-issue-workaround branch from 284a622 to c3a98d0 Compare May 11, 2022 13:47
lwronski
lwronski reviewed May 16, 2022
View reviewed changes
Copy link
Contributor
@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, in this kind of unobvious check we should add comment why there is exists case or at least add link to GitHub issue to see context of this exception.

@alexarchambault alexarchambault force-pushed the suggest-zip-issue-workaround branch from c3a98d0 to 9e3985a Compare May 16, 2022 09:34
@alexarchambault alexarchambault merged commit b72c688 into VirtusLab:main May 16, 2022
@alexarchambault alexarchambault deleted the suggest-zip-issue-workaround branch May 16, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@romanowski romanowski Awaiting requested review from romanowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexarchambault @lwronski
0