8000 Tweaking by alexarchambault · Pull Request #1087 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tweaking #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2022
Merged

Tweaking #1087

merged 9 commits into from
Jun 9, 2022

Conversation

alexarchambault
Copy link
Contributor

Bits of #926, moved here for easier review.

@alexarchambault
Don't set CI when running integration tests
d9edadc
@alexarchambault
Tweak cli option helpers
625bc3b 
- have the implicit classes extend AnyVal
- fix cached stuff
@alexarchambault
Use sonatype credentials from config in publish
30bb736
@alexarchambault
Tweak default workflow content
e851078 
As of now, it's using a custom Scala CLI launcher, via './scala-cli'.
As we don't install that custom launcher in users' projects, we use just
'scala-cli' instead.
@alexarchambault
Remove stale comment
a64275d
@alexarchambault
Slightly reorder commands in documentation
71db469
@alexarchambault
Slight refacto of config tests
3767939
8000
@alexarchambault alexarchambault marked this pull request as ready for review June 8, 2022 14:35
Gedochao
Gedochao approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor
@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the other comment is just a nitpick on formatting

@alexarchambault alexarchambault merged commit 18ac25d into VirtusLab:main Jun 9, 2022
@alexarchambault alexarchambault deleted the tweaking branch June 9, 2022 12:53
@Gedochao Gedochao added the internal Internal or build-related changes label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@lwronski lwronski Awaiting requested review from lwronski

Assignees
No one assigned
Labels
internal Internal or build-related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexarchambault @Gedochao
0