Turn the sip mode also for scala-cli-sip binary
#1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54bb6a2 to
4ef2329
Compare
Export and Package for now are excluded from the 'sip' mode.
4ef2329 to
da89c89
Compare
Gedochao
approved these changes
Jul 14, 2022
| @@ -41,6 +41,7 @@ import scala.util.Properties | |||
| object Package extends ScalaCommand[PackageOptions] { | |||
| override def name = "package" | |||
| override def group = "Main" | |||
| override def inSipScala = false | |||
There was a problem hiding this comment.
Why remove this one from the SIP binary? Generating a JAR is a pretty basic task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export and Package for now are excluded from the 'sip' mode.