8000 Prevent NPE from being thrown by the `export` sub-command if `testFramework` isn't defined by Gedochao · Pull Request #1814 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent NPE from being thrown by the export sub-command if testFramework isn't defined #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Prevent NPE from being thrown by the export sub-command if testFramework isn't defined #1814

merged 2 commits into from
Feb 1, 2023

Conversation

Gedochao
Copy link
Contributor

Fixes #1765

@Gedochao Gedochao added the bug Something isn't working label Jan 27, 2023
@Gedochao Gedochao marked this pull request as ready for review January 30, 2023 14:35
@Gedochao Gedochao force-pushed the export-test-framework-npe branch 2 times, most recently from 8df0b50 to 43b3273 Compare January 31, 2023 07:28
@Gedochao Gedochao force-pushed the export-test-framework-npe branch from 43b3273 to 58bed57 Compare January 31, 2023 08:52
@Gedochao Gedochao requested a review from lwronski January 31, 2023 08:53
@Gedochao Gedochao force-pushed the export-test-framework-npe branch 2 times, most recently from bd3c90d to 6c31a7d Compare February 1, 2023 14:19
lwronski
lwronski approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor
@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao force-pushed the export-test-framework-npe branch from 6c31a7d to 3cd82f2 Compare February 1, 2023 14:22
@Gedochao Gedochao enabled auto-merge February 1, 2023 14:29
@Gedochao Gedochao merged commit 661d8b6 into VirtusLab:main Feb 1, 2023
@Gedochao Gedochao deleted the export-test-framework-npe branch February 2, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE while exporting to sbt or mill
3 participants
@Gedochao @alexarchambault @lwronski
0