8000 Add extra class path to generated bootstrap launcher by lwronski · Pull Request #1897 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add extra class path to generated bootstrap launcher #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

Add extra class path to generated bootstrap launcher #1897

merged 1 commit into from
Mar 2, 2023

Conversation

lwronski
Copy link
Contributor
@lwronski lwronski commented Mar 1, 2023

Fixes #1891

@lwronski lwronski requested review from Gedochao and MaciejG604 March 1, 2023 21:39
Gedochao
Gedochao reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor
@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an anti-regression test?

@lwronski lwronski force-pushed the fix-package-fat-jar branch from 2ec1805 to 54a1599 Compare March 2, 2023 08:37
@lwronski lwronski requested a review from Gedochao March 2, 2023 08:38
@lwronski lwronski force-pushed the fix-package-fat-jar branch from 54a1599 to 8b24dbd Compare March 2, 2023 10:00
Gedochao
Gedochao approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor
@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwronski lwronski merged commit 5356185 into VirtusLab:main Mar 2, 2023
@Gedochao Gedochao added the bug Something isn't working label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sbt-assembly fat jars run fine using "run" command but not when packaged or turned into docker image
2 participants
@lwronski @Gedochao
0