8000 Improve build target names by MaciejG604 · Pull Request #2201 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve build target names #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

Improve build target names #2201

merged 1 commit into from
Jun 15, 2023

Conversation

MaciejG604
Copy link
Contributor
@MaciejG604 MaciejG604 commented Jun 9, 2023 •
edited
Loading

Fixes #2068

Instead of project_XYAZXYAX-SXYAYZYS use the name of the workspace directory to obtain:
workspace_XYAZXYAX-SXYAYZYS

E.g.

.
├── scripts
│   ├── .scala-build
│   │   └── scripts_59f2159dd5
│   └── one.sc
├── skan
│   ├── .scala-build
│   │   └── skan_88b44a2858
│   └── main.scala
└── skan.code-workspace

@MaciejG604 MaciejG604 requested a review from lwronski June 9, 2023 15:20
@MaciejG604 MaciejG604 force-pushed the improved-build-target-names branch from dc6ba03 to 738364e Compare June 13, 2023 08:27
@MaciejG604 MaciejG604 force-pushed the improved-build-target-names branch from 738364e to 4c62231 Compare June 13, 2023 08:38
tgodzik
tgodzik approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member
@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should actually be super helpful in metals.

lwronski
lwronski approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor
@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 merged commit da644ec into VirtusLab:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved build target names
3 participants
@MaciejG604 @tgodzik @lwronski
0