8000 Ensure build resolution is kept when packaging assemblies with provided dependencies by Gedochao · Pull Request #2457 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure build resolution is kept when packaging assemblies with provided dependencies #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Gedochao
Copy link
Contributor

Fixes #2456

TL;DR: packaging directives weren't properly respected when building assemblies with provided deps (or with Spark).

@Gedochao Gedochao requested a review from MaciejG604 October 10, 2023 12:45
Copy link
Member
@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gedochao Gedochao force-pushed the bug/fix-spark-assemblies branch from 6ccae55 to 60a5696 Compare October 11, 2023 07:29
@Gedochao Gedochao enabled auto-merge (squash) October 11, 2023 07:35
@Gedochao Gedochao merged commit 2fd3469 into VirtusLab:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Internal error: expected resolution to have been kept when using packaging.provided
2 participants
0