8000 `fix` sub-command tweaks by Gedochao · Pull Request #3646 · VirtusLab/scala-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix sub-command tweaks #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

fix sub-command tweaks #3646

merged 4 commits into from
Apr 28, 2025

Conversation

Gedochao
Copy link
Contributor

Some tweaks on fix sub-command behaviour

  • it will now respect the --test command line flag
    • scalafix rules may require .semanticdb files for test scope inputs, so the fix sub-command defaults to build the test scope as well (unlike other sub-commands)
    • however, if --test=false is explicitly passed, Scala CLI will now warn about it, but respect the option (and skip building the test scope, rather than silently ignore it as before)
  • it will now respect the --semanticdb flag
    • scalafix rules may require .semanticdb files for various rules, so the fix sub-command defaults to generate them as well (unlike other sub-commands)
    • however, if --test=false is explicitly passed, Scala CLI will now warn about it, but respect the option (and skip SemanticDB, rather than silently ignore it, as before)
  • Scala CLI will now pass the correct Scala version to scalafix, when the scala version was defined in a using directive
  • misc refactoring to achieve the above

@Gedochao Gedochao requested a review from tgodzik April 25, 2025 06:31
@Gedochao Gedochao marked this pull request as ready for review April 25, 2025 06:31
@Gedochao Gedochao force-pushed the feature/fix-tweaks branch from 6cb5b6e to 8faa13e Compare April 25, 2025 06:36
@Gedochao Gedochao requested review from tgodzik and removed request for tgodzik April 28, 2025 06:32
@Gedochao Gedochao merged commit 081f009 into VirtusLab:main Apr 28, 2025
54 checks passed
@Gedochao Gedochao deleted the feature/fix-tweaks branch April 28, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0