8000 [LANDGRIF-1144]: upgrade next to v13 by barbara-chaves · Pull Request #872 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[LANDGRIF-1144]: upgrade next to v13 #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

[LANDGRIF-1144]: upgrade next to v13 #872

merged 2 commits into from
Mar 14, 2023

Conversation

barbara-chaves
Copy link
Contributor
@barbara-chaves barbara-chaves commented Feb 16, 2023 •
edited
Loading

General description

This PR upgrades the Nextjs version to 13

  • upgrades next-auth and eslint-config-next versions to comply with Nextjs 13;
  • refactor next/Image and next/Link components and custom components based on them;

Testing instructions

Be sure that all pages are rendering and working

Related task

LANDGRIF-1144

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link
vercel bot commented Feb 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 11:58AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Mar 10, 2023 at 11:58AM (UTC)

@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from b0d45e3 to efc9bfa Compare February 20, 2023 15:13
@barbara-chaves barbara-chaves self-assigned this Feb 20, 2023
agnlez
agnlez requested changes Feb 21, 2023
View reviewed changes
Copy link
Member
@agnlez agnlez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Just keep tests as they are in dev so we can notice if something breaks. Only changes strictly related to the Next@13 bump should appear in the PR.

@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from efc9bfa to 06f58d7 Compare February 21, 2023 09:37
@agnlez
Copy link
Member
agnlez commented Feb 23, 2023

@barbara-chaves mind rebasing and fixing conflicts with dev branch, please? Also, looks like some commits from Alex went to this branch, could you please remove them?

@alexeh alexeh force-pushed the dev branch 2 times, most recently from 81763b1 to f876633 Compare February 24, 2023 08:30
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from d9658a3 to 058b558 Compare February 24, 2023 09:33
@agnlez agnlez changed the title refactor: upgrade next to v13 [LANDGRIF-1144]: upgrade next to v13 Feb 27, 2023
@agnlez agnlez force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from 058b558 to af54316 Compare February 27, 2023 09:27
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from af54316 to 0637b20 Compare February 27, 2023 10:28
@alexeh alexeh force-pushed the dev branch 2 times, most recently from 868d19a to 0e30ca5 Compare February 27, 2023 13:12
@alexeh alexeh force-pushed the dev branch 3 times, most recently from e072d47 to 0740fd3 Compare February 27, 2023 13:47
@alexeh alexeh force-pushed the dev branch 7 times, most recently from 2fff34a to 8a3eb61 Compare March 3, 2023 04:44
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from 0edaba9 to 3ed4c3c Compare March 6, 2023 11:47
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from 3ed4c3c to 0a1c894 Compare March 6, 2023 16:50
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from 0a1c894 to 6365382 Compare March 7, 2023 17:10
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from 6365382 to 90f9e54 Compare March 8, 2023 11:58
barbara-chaves and others added 2 commits March 10, 2023 12:53
@barbara-chaves @agnlez
refactor: upgrade next to v13
5c18b47 
Fix auth jwt callback

Fix Anchor component

Remove unused imported Link

update signup test
@agnlez
next@13.2.4
a633673
@agnlez agnlez force-pushed the client/feature/LANDGRIF-1144-upgrade-next branch from e1b4813 to a633673 Compare March 10, 2023 11:53
@davidsingal davidsingal merged commit 68eb3c9 into dev Mar 14, 2023
@davidsingal davidsingal deleted the client/feature/LANDGRIF-1144-upgrade-next branch March 14, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnlez agnlez agnlez approved these changes

@davidsingal davidsingal Awaiting requested review from davidsingal

Assignees

@barbara-chaves barbara-chaves

Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barbara-chaves @agnlez @davidsingal
0