8000 fix(impact tables): Fixes incorrect locationType filtering on Impact … by KevSanchez · Pull Request #889 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(impact tables): Fixes incorrect locationType filtering on Impact … #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix(impact tables): Fixes incorrect locationType filtering on Impact … #889

merged 1 commit into from
Feb 27, 2023

Conversation

KevSanchez
Copy link
Contributor

…Tables

Fixes a bug where locationType was ignored when retrieving the groupBy entities for the skeleton of ImpactTables, and fixes tables grouped by locationType showing entities with no data Also adds a custom Jest Matcher to test array equalness without considering order

General description

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@KevSanchez
fix(impact tables): Fixes incorrect locationType filtering on Impact …
07c39e2 
…Tables

Fixes a bug where locationType was ignored when retrieving the groupBy entities for the skeleton of ImpactTables, and fixes tables grouped by locationType showing entities with no data
Also adds a custom Jest Matcher to test array equalness without considering order
@vercel
Copy link
vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
landgriffon-client ⬜️ Ignored (Inspect) Feb 24, 2023 at 3:47PM (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Feb 24, 2023 at 3:47PM (UTC)

@KevSanchez KevSanchez merged commit 85a0098 into staging Feb 27, 2023
@KevSanchez KevSanchez deleted the hotix/LANDGRIF-1250-incorrect-behavior-location-type-impact-table branch February 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeh alexeh Awaiting requested review from alexeh

@yulia-bel yulia-bel Awaiting requested review from yulia-bel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevSanchez
0