(bugfix) LANDGRIF-1210 - Fix update user roles #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
fde12de to
8aede6b
Compare
yulia-bel
approved these changes
Mar 7, 2023
alexeh
commented
Mar 7, 2023
| @@ -183,4 +183,17 @@ export class UsersService extends AppBaseService< | |||
| async deleteUser(userId: string): Promise<DeleteResult> { | |||
| return this.repository.delete(userId); | |||
| } | |||
|
|
|||
| async updateUser(userId: string, updateUser: any): Promise<User> { | |||
alexeh
commented
Mar 7, 2023
| @@ -282,4 +284,8 @@ export class AuthenticationService { | |||
| throw new ConflictException('Email already exists.'); | |||
| } | |||
| } | |||
|
|
|||
| updateRoles(rolesEnum: ROLES[]): Role[] { | |||
There was a problem hiding this comment.
better naming:
get role entities
create roles from names
8aede6b to
6c878e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General description
This PR fixes a bug where roles where not updating for a user.
The roles are sent as a array of strings which has to be converted to a proper entity before saving them to the database.
Using a basic update statement by typeorm repository, the entity will get updated by the values that matches the entity, and it will return the same DTO that has consumed, meaning that, during updating, the array of strings
roleswill be ignored, but it will be returnedDesigns
Link to the related design prototypes (if applicable)
Testing instructions
Given a admin role, update any users roles via PATCH /user.
It will return the roles as entities in the role property in the user object, plus some permissions associated. if any role has any
Checklist before merging