8000 [LANDGRIF-1246]: fixes weird behaviour of coefficients panel by agnlez · Pull Request #910 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[LANDGRIF-1246]: fixes weird behaviour of coefficients panel #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to o 8000 ur terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

[LANDGRIF-1246]: fixes weird behaviour of coefficients panel #910

merged 1 commit into from
Mar 8, 2023

Conversation

agnlez
Copy link
Member
@agnlez agnlez commented Mar 7, 2023 •
edited
Loading

General description

https://vizzuality.atlassian.net/browse/LANDGRIF-1246

Fixes issue toggling coefficients panel in intervention form. Now the panel is static (no way to handle open/close states) when the intervention type is Change production efficiency. Also, the panel will be open by default whenever the intervention type is Change production efficiency and coefficients are modified. Swapping to other intervention types will close the panel if coefficients are not modified.

image

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@agnlez agnlez requested a review from davidsingal March 7, 2023 11:55
@agnlez agnlez self-assigned this Mar 7, 2023
@vercel
Copy link
vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
landgriffon-client ✅ Ready (Inspect) Visit Preview Mar 7, 2023 at 11:55AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Mar 7, 2023 at 11:55AM (UTC)

@davidsingal davidsingal merged commit d09954c into dev Mar 8, 2023
@davidsingal davidsingal deleted the LANDGRIF-1246-coefficients-panel-acting branch March 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsingal davidsingal davidsingal approved these changes

Assignees

@agnlez agnlez

Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnlez @davidsingal
0