8000 fix years selection invalid range bug by barbara-chaves · Pull Request #927 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix years selection invalid range bug #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix years selection invalid range bug #927

merged 1 commit into from
Mar 30, 2023

Conversation

barbara-chaves
Copy link
Contributor
@barbara-chaves barbara-chaves commented Mar 28, 2023 •
edited
Loading

General description

This PR fixes the invalid range bug

Testing instructions

In analysis page, change from map to table visualisation.
The message Years gap cannot be respected; not enough years data should NOT be displayed

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
< 8000 div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-1486471751">
Copy link
vercel bot commented Mar 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 9:00AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Mar 28, 2023 at 9:00AM (UTC)

@barbara-chaves barbara-chaves self-assigned this Mar 28, 2023
@barbara-chaves barbara-chaves added bug Something isn't working front-end labels Mar 28, 2023
@davidsingal davidsingal merged commit 33dbea8 into dev Mar 30, 2023
@davidsingal davidsingal deleted the client/bugfix/LANDGRIF-1258-years-gap-issue branch March 30, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsingal davidsingal davidsingal approved these changes

Assignees

@barbara-chaves barbara-chaves

Labels
bug Something isn't working front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbara-chaves @davidsingal
0