8000 (feat) LANDGRIF-1279 check scenario permissions for comparisons by alexeh · Pull Request #931 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(feat) LANDGRIF-1279 check scenario permissions for comparisons #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, yo 8000 u agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2023
Merged

(feat) LANDGRIF-1279 check scenario permissions for comparisons #931

merged 4 commits into from
Apr 3, 2023

Conversation

alexeh
Copy link
Collaborator
@alexeh alexeh commented Apr 3, 2023 •
edited
Loading

General description

Checks auth over scenarios when it comes to comparison request, that is, tables and charts

Due to a handicap in the FE, this needs to be also checked in the API

Designs

Link to the related design prototypes (if applicable)

Testing instructions

These should be the use cases in the scope of this PR

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link
vercel bot commented Apr 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-client ⬜️ Ignored (Inspect) Apr 3, 2023 9:57am
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Apr 3, 2023 9:57am

@alexeh alexeh force-pushed the feature/LANDGRIF-1279-check-scenario-permissions-for-comparisons branch from 36f56b5 to 47e2bf8 Compare April 3, 2023 08:54
@alexeh alexeh merged commit 83016ad into dev Apr 3, 2023
@alexeh alexeh deleted the feature/LANDGRIF-1279-check-scenario-permissions-for-comparisons branch July 10, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexeh
0