8000 Change layer legend info from tooltip to modal by barbara-chaves · Pull Request #960 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change layer legend info from tooltip to modal #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2023
Merged

Change layer legend info from tooltip to modal #960

merged 3 commits into from
Jun 6, 2023

Conversation

barbara-chaves
Copy link
Contributor
@barbara-chaves barbara-chaves commented May 22, 2023 •
edited
Loading

General description

This PR changes the layers legend info display from tooltip to a modal.

Designs

https://www.figma.com/file/7bmF29CIXDJwCpuloW5Nt6/%F0%9F%94%B5-Landgriffon---Redesign_BLUE?type=design&node-id=3386-112237&t=rjf3h2QaABkGtz4T-4

Related task

LANDGRIF-1341

Testing instructions

  1. Add the 3 types of layers on the /analysis/map.
  2. Open the legends info
  3. Be sure that the title description and sources are being shown correctly

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link
vercel bot commented May 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 7:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Jun 2, 2023 7:59am

@barbara-chaves barbara-chaves self-assigned this May 22, 2023
davidsingal
davidsingal approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor
@davidsingal davidsingal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a change in the design is missing, please review and after the amendment feel free to merge

@davidsingal davidsingal force-pushed the client/feature/LANDGRIF-1341-change-the-way-to-show-the-source branch from 3880aac to c3496ed Compare June 2, 2023 07:52
@davidsingal davidsingal merged commit b0e728d into dev Jun 6, 2023
@davidsingal davidsingal deleted the client/feature/LANDGRIF-1341-change-the-way-to-show-the-source branch June 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsingal davidsingal davidsingal approved these changes

Assignees

@barbara-chaves barbara-chaves

Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbara-chaves @davidsingal
0