10000 add grey water footprint indicator coefficient csv by elpamart · Pull Request #1021 · Vizzuality/landgriffon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add grey water footprint indicator coefficient csv #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2023
Merged

add grey water footprint indicator coefficient csv #1021

merged 6 commits into from
Aug 23, 2023

Conversation

elpamart
Copy link
Contributor
@elpamart elpamart commented Jul 12, 2023 •
edited
Loading

General description

This PR includes:

  • Grey water footprint csv at country and administrative level for different materials. This dataset is used as part of the water quality indicator.
  • Updated code to ingest the grey water footprint csv as part of the indicator coeficients
  • Updates to the base data importer units and indicators csv to include the new indicators. These new indicators are:
  1. Water quality
  2. Water quality target
  3. GHG emissions
  4. Land conversion

Testing instructions:

  • Ingest the base data importer and make sure that is ingested correctly
  • Ingest the indicators coefficients and make sure that they are correctly linked with the indicatorId, material and location.

@elpamart elpamart added the WIP Work In Progress label Jul 12, 2023
@elpamart elpamart requested a review from BielStela July 12, 2023 12:50
@vercel
Copy link
vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-client ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:03am
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:03am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:03am

@elpamart elpamart removed the WIP Work In Progress label Jul 19, 2023
@elpamart elpamart requested a review from alexeh July 19, 2023 09:58
BielStela
BielStela requested changes Jul 19, 2023
View reviewed changes
data/indicator_coefficient_importer/Makefile Outdated

grey-water-indicator-coefficients:
python indicator_coefficient_importer.py data/bwfp_indicator_coefficients.csv WQ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be gwfp_indicator_coefficients.csv ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what the meaning of WQ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry. I'm going to change it. and WQ is the short name of the new water quality indicator. We should have that reference in the indicator csv.

BielStela
BielStela previously approved these changes Jul 19, 2023
View reviewed changes
@BielStela BielStela force-pushed the LANDGRIF-1426-prepare-indicator-coefficient-csv-to-include-grey-water_v2 branch from 9e5bbe5 to 453cc61 Compare August 16, 2023 11:19
@BielStela BielStela self-requested a review August 18, 2023 14:52
@BielStela BielStela dismissed their stale review August 18, 2023 14:53

new changes

@elpamart elpamart merged commit a2a61ff into dev Aug 23, 2023
@elpamart elpamart deleted the LANDGRIF-1426-prepare-indicator-coefficient-csv-to-include-grey-water_v2 branch August 23, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeh alexeh Awaiting requested review from alexeh

@BielStela BielStela Awaiting requested review from BielStela

Assignees
No one assigned
Labels
science
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpamart @BielStela
0