8000 Change resource parser from reference to pointer by ben9923 · Pull Request #472 · VoodooI2C/VoodooI2C · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change resource parser from reference to pointer #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

Change resource parser from reference to pointer #472

merged 1 commit into from
Sep 8, 2021

Conversation

ben9923
Copy link
Member
@ben9923 ben9923 commented Sep 8, 2021

Linter forbids it due to usage of non-const reference.
It cannot be a const as the parser alters itself during the processing.

@ben9923
Change resource parser from reference to pointer
b609f22 
Linter forbids it due to usage of non-const reference.
It cannot be a const as the parser alters itself during the processing.
@ben9923 ben9923 requested a review from kprinssu September 8, 2021 17:00
@kprinssu
Copy link
Collaborator
kprinssu commented Sep 8, 2021

Looks good to me @ben9923

@ben9923 ben9923 merged commit 9ddc72a into master Sep 8, 2021
@ben9923 ben9923 deleted the fix/nub-parser-reference branch September 8, 2021 22:19
@stevezhengshiqi
Copy link
Contributor

Hi @ben9923 . It seems that this commit makes my ETD2303 unresponsive. My machine is a KBL laptop. The log is like

2021-10-10 22:20:30.701615-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::Loading GPIO Data for SunrisePoint-LP
2021-10-10 22:20:30.701627-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::VoodooGPIO Init!
2021-10-10 22:20:30.701630-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 0
2021-10-10 22:20:30.701659-0700  localhost kernel[0]: (VoodooI2CHID) VoodooI2CSensorHubEnabler::INT33D0 Found Intel ACPI Sensor Hub Enabler
2021-10-10 22:20:30.701673-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 1
2021-10-10 22:20:30.701706-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 2
2021-10-10 22:20:30.701804-0700  localhost kernel[0]: (VoodooGPIO) VoodooGPIOSunrisePointLP::GPIO Controller is already awake! Not reinitializing.
2021-10-10 22:20:30.702068-0700  localhost kernel[0]: (VoodooI2CHID) VoodooI2CSensorHubEnabler::INT33D0 Enabled Sensor Hub

@stevezhengshiqi
Copy link
Contributor

Here's the updated log by adding DebugEnhancer:

[    0.635504]: VoodooGPIOSunrisePointLP::Loading GPIO Data for SunrisePoint-LP
[    0.635512]: VoodooGPIOSunrisePointLP::VoodooGPIO Init!
[    0.635513]: VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 0
[    0.635559]: VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 1
[    0.635586]: VoodooGPIOSunrisePointLP::VoodooGPIO Initializing Community 2
[    0.635703]: VoodooGPIOSunrisePointLP::GPIO Controller is already awake! Not reinitializing.
[    0.636067]: VoodooI2CSensorHubEnabler::INT33D0 Found Intel ACPI Sensor Hub Enabler
[    0.636223]: VoodooI2CSensorHubEnabler::INT33D0 Enabled Sensor Hub
[    0.676612]: VoodooI2CPCIController::pci8086,9d61 Starting I2C controller
[    0.676641]: VoodooI2CPCIController::pci8086,9d61 Set PCI power state D0
[    0.676659]: VoodooI2CPCIController::pci8086,9d61 Publishing nub
[    0.676989]: VoodooI2CControllerDriver::pci8086,9d61 Probing controller
[    0.677275]: VoodooI2CControllerDriver::pci8086,9d61 Found valid Synopsys component, continuing with initialisation
[    0.678457]: VoodooI2CPCIController::pci8086,9d60 Starting I2C controller
[    0.678481]: VoodooI2CControllerNub::pci8086,9d61 SSCN not implemented in ACPI tables
[    0.678488]: VoodooI2CControllerNub::pci8086,9d61 FMCN not implemented in ACPI tables
[    0.678489]: VoodooI2CPCIController::pci8086,9d60 Set PCI power state D0
[    0.678492]: VoodooI2CControllerDriver::pci8086,9d61 Warning: Error getting bus config, using defaults where necessary
[    0.678564]: VoodooI2CControllerDriver::pci8086,9d61 Publishing device nubs
[    0.678603]: VoodooI2CPCIController::pci8086,9d60 Publishing nub
[    0.683476]: VoodooI2CControllerDriver::pci8086,9d60 Probing controller
[    0.683482]: VoodooI2CControllerDriver::pci8086,9d60 Found valid Synopsys component, continuing with initialisation
[    0.683774]: VoodooI2CControllerNub::pci8086,9d60 SSCN not implemented in ACPI tables
[    0.683781]: VoodooI2CControllerNub::pci8086,9d60 FMCN not implemented in ACPI tables
[    0.683784]: VoodooI2CControllerDriver::pci8086,9d60 Warning: Error getting bus config, using defaults where necessary
[    0.684037]: VoodooI2CControllerDriver::pci8086,9d60 Publishing device nubs
[    0.684043]: VoodooI2CControllerDriver::pci8086,9d60 Found I2C device: ETD2303
[    0.684130]: VoodooI2CDeviceNub::TPD0 Found valid resources from _CRS method
[    0.684321]: VoodooI2CDeviceNub::TPD0 Found valid resources from _DSM or XDSM method
[    0.684330]: VoodooI2CDeviceNub::TPD0 Prefer resources from _DSM or XDSM method
[    0.684342]: VoodooI2CDeviceNub::TPD0 Found valid GPIO interrupts
[    0.684350]: VoodooI2CDeviceNub::TPD0 Got GPIO Controller! VoodooGPIOSunrisePointLP
[    1.185194]: VoodooI2CControllerDriver::pci8086,9d60 I2C Transaction error details
[    1.185204]: VoodooI2CControllerDriver::pci8086,9d60 lost arbitration
[    1.185208]: VoodooI2CControllerDriver::pci8086,9d60 I2C Transaction error: 0x01001000 - aborting
[    1.185216]: VoodooI2CHIDDevice::ETD2303 Request for HID descriptor failed
[    1.185228]: VoodooI2CHIDDevice::ETD2303 Could not get HID descriptor

I will try to post a issue about this when I have time. Sorry for making a mess here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprinssu kprinssu kprinssu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben9923 @kprinssu @stevezhengshiqi
0