Fix for a critical bug introduced in #473 #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`memset` clears `bus_device` when `VoodooI2CControllerDriver::init` is called
kprinssu
approved these changes
Oct 13, 2021
|
@ben9923 Feel free to merge it in. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ben9923!
I apologize for not testing the suggestion from the previous PR thoroughly.
VoodooI2C/VoodooI2C/VoodooI2C/VoodooI2CController/VoodooI2CControllerDriver.cpp
Line 134 in 5bdded8
memsetclears outbus_devicewhenVoodooI2CControllerDriver::initis called. As a result, all config values will remain as 0 if nothing valid was returned from ACPI.Huge thanks to @stevezhengshiqi for pointing out the issue and testing the experimental builds.