feat: implement a wikiracer #1
Conversation
There was a problem hiding this comment.
Feel free to fix your program — it currently produces incorrect results for the input:
https://en.wikipedia.org/wiki/Arithmetic_shift, https://en.wikipedia.org/wiki/Adolf_Hitler
There is a path of 2 pages between them.
You’re welcome to update your solution, and I will update the mark.
The current mark is 4 (maximum is 14).
| } | ||
|
|
||
| override suspend fun getReferences(page: String): List<String> { | ||
| val url = if (page.startsWith("https://")) page else "https://$page" |
| @@ -25,8 +27,8 @@ internal class ParsingTest { | |||
| fun referencesData() = listOf( | |||
| Arguments.of( | |||
| "https://en.wikipedia.org/wiki/Kotlin_(programming_language)aaaaa", | |||
| emptyList<String>(), | |||
There was a problem hiding this comment.
Why did you change it? It was correct answer
| val searchDepth: Int by option("-d", "--depth", help = "Search depth").int().default(4) | ||
| val threads: Int by option("-t", "--threads", help = "Number of threads").int().default(8) | ||
|
|
||
| override fun run() { |
| val dispatcher = Dispatchers.IO.limitedParallelism(maxThreads) | ||
| val client = HttpClient() | ||
|
|
||
| override fun race( |
There was a problem hiding this comment.
In the search method, all arguments are on one line; in the race method, all arguments are on the next line; and in processLevels, each argument is on a separate line. It would be better to follow a consistent formatting style across all methods. Consider configuring a static analyzer to enforce and automate this structure.
| } | ||
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) | ||
| class AsyncRacer(maxThreads: Int) : WikiRacer { |
There was a problem hiding this comment.
The AsyncRacer class contains two methods that are too large and complex. It would be helpful to break them down into smaller, well-named methods to improve readability and make it easier for others to understand what each part of the code does.
No description provided.