Clarify ARIA, AOM and computed attributes #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minorninth
reviewed
Mar 17, 2017
| @@ -341,70 +348,77 @@ input.accessibleNode.activeDescendant = optionList.accessibleNode; | |||
|
|
|||
| This would allow the relationship to be expressed naturally. | |||
|
|
|||
| #### No reflection | |||
| #### AOM and ARIA | |||
There was a problem hiding this comment.
It may be obvious but should we explicitly define AOM the first time before using it as an acronym?
minorninth
reviewed
Mar 17, 2017
explainer.md
Outdated
| `clickBtn` would have a computed role of `"button"` | ||
| even though its `accessibleNode` has a `role` of `"link"`. | ||
|
|
||
| This means that: |
There was a problem hiding this comment.
This final paragraph sums up the overall "No reflection" section, but it appears to just be part of the "ARIA takes precedence" section. Maybe it needs a tiny subheading too?
minorninth
reviewed
Mar 17, 2017
explainer.md
Outdated
| it needs to work consistently across browsers, | ||
| so that developers don't need to write special case code for each. | ||
|
|
||
| Before we can create an API which allows accessing the computed properties, |
There was a problem hiding this comment.
This sentence is kind of redundant with the previous paragraph. How about something like, we believe it will be possible to create an API that's consistent but it's significantly more complicated than the first three phases.
There was a problem hiding this comment.
Agreed re redundancy; reworded slightly differently from your suggestion.
minorninth
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cookiecrook @minorninth @asurkov PTAL