Fix: Improper reinitialization of maintenance event timing #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Improper reinitialization of maintenance event timing
This PR fixes an uncaught bug in the development of the date-based maintenance feature released in 0.10. When a subassembly is replaced, the conversion of the user input to a timeout schedule was triggered again. This reinitialization caused runs to fail because of improper type interactions. This update ensures the setup logic is only run at subassembly initialization.
PR Checklist
RELEASE.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessary - N/ARelated issues
N/A
Impacted areas of the software
test/test_subassembly.pytest/test_data_classes.pywombat/windfarm/system/cable.pywombat/windfarm/system/subassembly.pywombat/core/environment.py: fixes a future warning for pandas offsetswombat/core/data_classes.py: change buffer from 1 hour to 1 dayAdditional supporting information
Python version: 3.x
WOMBAT version (
wombat.__version__): 0.xTest results, if applicable