Remove https: and http: from LESS customizer output #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnagle
added a commit
that referenced
this pull request
Aug 7, 2015
Remove https: and http: from LESS customizer output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
http:andhttps:from the compiled custom stylesheet, so that all links will start with//and be protocol-agnostic. (For Make sure Largo is generally safe for HTTPS #811)example.orgThis does not include tests.
Why
Because, though our stylesheets use relative links to all the resources, including fonts, the customizer output replaces relative paths with
get_template_directory_uri(), which keeps the protocol of the page that the admin was loaded with when the "Save Variables" button is pressed in the admin.Modernizr: misc bugfixes, I guess
Docstring: Because IANA standards matter, and I saw it while looking for
http: